Hi all,
At this point, we have a general discussion list for the umbrella
project that is Identity Python (idpy-discuss at lists.sunet.se). We also
have a specific dev list for Satosa (satosa-dev at lists.sunet.se). Given
we have formally accepted pyff, pysaml, and pyXMLSecurity into the idpy
project, can we create targeted dev lists for them as well? Or do those
lists already exist?
Thanks!
Heather
Attendees:
Ivan, Heather, Scott, John
Action item:
* Heather to work with Ivan to create a shared admin account to manage
mailing list, slack, other tools as needed
* Heather to create templates for PRs and Issues
* Heather to add notes as needed to the PRs from today’s call
* Scott will re-run the tests for pyFF PR 118; if the test is actually
broken, Scott will write up an issue that there is a bad test.
0. Agenda bash
Set up an admin account to manage mailing list and slack.
1. Establishing a PR template -
https://github.com/blog/2111-issue-and-pull-request-templates
* Do we want to have a similar template for issues?
Yes, we want templates for both.
Two sections for a PR template: what problem are you trying to solve,
and what the solution is and why that solution and not something else
For issues: Include a pointer to documentation, what version is being
used, what branch are you using
2. Satosa pull requests (no more than 10 minutes each) -
https://github.com/IdentityPython/SATOSA
- #172 - fairly self contained. Ivan has’t tested the code yet. He
will do that, and assuming the code passes tests, will merge it. Scott
notes that the code is being used in production on a particular project
off a different branch.
- #137 - from Ivan’s email "needs to be refactored - part of it is
already there, part of it is useful, part of it belongs to pysaml2”.
Some of this needs to move to pySAML, and other changes are already made
by other commits. What’s missing is what the title says: adding the
nameID format. That’s easy to do, and something Ivan can do fairly
easily. There is a checkbox when you create a pull request that would
allow the project developer to change the commit. That was set for this,
so Ivan will directly edit the pull request.
- #166 - Ivan would like to reproduce this to figure out what
exactly is the problem. What is being done in the PR is capture every
exception and presenting an error, which might not be the best path
forward. This is not a fix, just a presentation of errors. Ask Rainer to
create a test for this issue so we can understand the full failure mode.
John adding that as a comment to the PR, Scott will add a request for
clarification to the Issue.
- #171 - Ivan has to review this one in more detail. This one could
very much use the template to explain what and why this PR exists. There
is no description around how this works or why it’s built this way.
3. pySAML2 - still needs to move to the IdentityPython repository
- #483 Enable signature verification for MDQ - This seems to be
fine. It does what it needs to do. It is related to Issue 448. Scott
will be writing some tests. When that is done, this and 485 can be merged.
- #485 Add want_assertions_or_response_signed functionality - Ivan
still needs to review this one. Scott reports this one is problematic -
this is the only way Scott can see to make this happen given how the
code is currently structured. It is ugly, but no obvious other way to do
it without a heavy refactor or the the pySAML code base. Scott will be
writing tests on this one (priority over 483)
4. AOB
pyFF: Failure of Travis CI build - what do we need to do about this
error? Someone needs to go back and review/fix the test that is causing
this to fail. Fixing the test should be a separate pull request. Scott
will re-run the tests for pyFF PR 118; if the test is actually broken,
Scott will write up an issue that there is a bad test.
Hi all,
Apologies for the lateness in getting this out. The mailing list
software ate the original meeting invitation, which I hadn't realized
until late last night. I've sent a revised invitation with the BlueJeans
link to the list from my own account; that should make its way through.
BlueJeans: https://bluejeans.com/655841213
Agenda
0. Agenda bash
1. Establishing a PR template -
https://github.com/blog/2111-issue-and-pull-request-templates
2. Satosa pull requests (no more than 10 minutes each) -
https://github.com/IdentityPython/SATOSA
- #172
- #137
- #166
- #171
3. pySAML2 - still needs to move to the IdentityPython repository
- #483 Enable signature verification for MDQ
- #485 Add want_assertions_or_response_signed functionality
4. AOB
Hi all,
I'd like to set up regular calls for folks to discuss open pull
requests. I'm thinking an hour every other week, with a maximum of 30
minutes on any single pull request. There will have to be a certain
amount of scheduling magic to make sure the submitter is on the call to
discuss, but that'll be my problem to coordinate.
Any objections? Or would folks prefer this to be weekly, at least until
we get through the existing backlog of requests?
-Heather
Hi all,
As discussed on the list:
https://doodle.com/poll/eq62cnivkkkndzaw
This would start next week, and go until we don't have anything else to
talk about.
-Heather
Accomplishments:
1. Agreed to projects to include in idpy (current list = Satosa, pyff,
pySAML, pyXMLsecurity)
2.
1. discussion on the OIDC related ones somewhat dependent on future
governance decisions
3. Agreed to a plan for how to work through existing pull requests
until such time as we have a dedicated benevolent dictator
4. Reviewed three pull requests for Satosa (174, 171, 161)
5. Discussed prioritization for Satosa/pySAML
6.
1. Clean up Satosa code base, including writing tests
2.
1. fixing logging, error handling
2. more structured documentation on how to import microservices
3. Bigger Satosa refactoring
4.
1. pulling out networking; this will almost certainly have to
touch on pySAML and its refactoring
Action items:
1. Governance items
2.
1. Heather to create an evaluation matrix for potential IPR home
based on criteria proposed by Niels, Benn from previous efforts
to look at IPR homes for OpenConext, Cyrus
2. Roland needs to move pySAML to the IdentityPython repository
3. Heather to update idpy.org <http://idpy.org> with GitHub links,
other info from the meeting
4. Satosa updates
5.
1. Martin to split pull request 161
2. Heather to make sure Niels and Ivan talk about 171
3. Scott has homework (?) re: 174
Next steps:
1. Governance
2.
1. idpy developers to review IPR home matrix and make decision
2. Community outreach re: governance decisions/recommendations
3. CLA - text and signing
3. Technical architecture
4.
1. Finish evaluating Satosa pull requests
2. Continue to develop additional, better tests
3. pyFF development (currently RA21 focused)
plan B - a process to accept pull requests and do proper releases
* No development on the master.
* Unit tests must pass before merged into Master. A test may need to
be written to validate; a test is always required.
*
o Measure test coverage with Coverall (?). If the new code (bug
fix or RFE) comes in on a place with few tests, then need test
needs to be written. If there are a lot of tests, then committer
should at least look at the test to see if it is likely to be valid.
* Each version has to be tagged with dependencies
* Peer review - someone posts to the list, describes how/why and
points to a pull request; at least one approver (and the approver
has to be someone who is approved to commit code and who isn’t a
member of the same organization)
* Stable releases should be posted to PyPI